[Grub-dev] Small error in protocol definition

[Giorgos Logiotatidis]

On Σαβ, 2009-01-17 at 10:28 +0100, Bartek Jasicki wrote:
> On 2009-01-17, at 00:57:10
> Balinny <balinny at gmail.com> wrote:
> 
> > Giorgos Logiotatidis wrote:
> > > Hello,
> > > 	I found a small error while trying to fix the 401 problem
> > > my python client throws. 
> > >
> > > In [1], section 2 the size of the "Invalid URL" message is wrong
> > >
> > > The page says 
> > > """
> > > http://test 0.0.0.0 20080916122745 application/x-grub-error 39\n
> > > HTTP/1.0 500 Invalid URL\r\n
> > > \r\n
> > > Invalid URL\r\n
> > > """
> > >
> > > while it should say
> > > """
> > > http://test 0.0.0.0 20080916122745 application/x-grub-error 41\n
> > > HTTP/1.0 500 Invalid URL\r\n
> > > \r\n
> > > Invalid URL\r\n
> > > """
> > >
> > > Well changing that in the python client, did not cure the 401
> > > problem so I guess the server doesn't really care about that, but
> > > anyway that should be fixed :)
> > >   
> > Nope. All ARC chunks end with \n (not \r\n as it seems to assume).
> > That new line at the end is ending the
> > chunk, not part of the web page (although many webs have leading new
> > lines, which *do* pertain to the body).
> > Although the server seemed to cope well without the ending \n at the
> > end of the arc file (which IMHO is an error).
> > 
> > You can (directly) send me one of those failing files you produce.
> > I'll happily take a look on where the problem may lie.
> > 
> 
> Hi
> 
> You both have right ;) Giorgos - with invalid information in
> documentation, Balinny - found where is bug ;) Yes, every record
> in .arc file must end with "\n" not "\r\n", my bad, sorry.
> Documentation fixed ;) If you still been have any problems with
> invalid .arc files - you can try send it to new Grub server - it
> produce little more verbose messages about problems ;)
> 
> Bartek

;) Thanks for fixing that!

-g